fix: Add linux_riscv64 to _pip_repository_impl #3350

kxxt · 2025-10-14T11:53:21Z

Add linux_riscv64 support for pulling pip dependencies. This is not
adding any hermetic toolchain support - user has to provide a working
toolchain.

Fix #2729

gemini-code-assist · 2025-10-14T11:53:33Z

Summary of Changes

Hello @kxxt, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the rules_python framework by integrating linux_riscv64 support into the _pip_repository_impl function. This crucial update ensures that Python package dependencies can be correctly resolved and built on RISC-V 64-bit architectures, directly addressing and fixing a known build issue for projects like TensorFlow on this platform. The change improves the overall robustness and platform compatibility of the Bazel Python rules.

Highlights

Platform Support: Added linux_riscv64 to the list of supported platforms within the _pip_repository_impl function, enabling broader compatibility.
Bug Fix: This change resolves a reported build issue for TensorFlow on RISC-V 64-bit systems, specifically addressing the problem discussed in GitHub issue Repository '@@pypi_{PACKAGE_NAME}' is not defined error on riscv64 #2729.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request correctly adds linux_riscv64 to the list of supported platforms in _pip_repository_impl, which is a good first step towards supporting this architecture. However, the fix appears to be incomplete. For full support, especially for parsing wheel filenames, the wheel platform tag parser also needs to be updated to recognize the riscv64 architecture. I've left a detailed comment on the .bzl file change with guidance on how to complete the implementation.

python/private/pypi/pip_repository.bzl

Fix bazel-contrib#2729

CI fails with connection timed out

kxxt · 2025-10-14T12:47:34Z

It appears that docs/readthedocs.org:rules-python CI is failing due to network errors.

aignas · 2025-10-15T02:53:09Z

FYI @meteorcloudy, @rickeylev, recently the macos build has been flaking a lot download errors like this.

https://buildkite.com/bazel/rules-python-python/builds/13390/steps/canvas?sid=0199e5be-8ed2-4523-bbc5-0e7a944731c8

~~Gonna merge it with a bypass.~~

aignas · 2025-10-15T02:55:37Z

@kxxt, could you please retest your PR with the latest? We have enabled a particular feature of rules_python (#3225) and I am wondering if your PR is sufficient to still have the tensorflow building correctly.

kxxt · 2025-10-15T03:06:51Z

@kxxt, could you please retest your PR with the latest? We have enabled a particular feature of rules_python (#3225) and I am wondering if your PR is sufficient to still have the tensorflow building correctly.

Thanks for the heads-up. I tested this PR by converting it to a patch based on rules_python 1.6.0 to use in tensorflow's //third_party/py. I will try to test it with rules_python 1.7.0.

bazel-contrib/rules_python#3350

meteorcloudy · 2025-10-15T08:43:35Z

Yes, sorry we are having some CI outage for macOS workers: bazelbuild/continuous-integration#2385

bazel-contrib/rules_python#1907 bazel-contrib/rules_python#3350

kxxt · 2025-10-18T01:45:29Z

@kxxt, could you please retest your PR with the latest? We have enabled a particular feature of rules_python (#3225) and I am wondering if your PR is sufficient to still have the tensorflow building correctly.

Hi, @aignas. I tested this PR again by bumping tensorflow's rules_python to 1.7.0-rc0, which includes the
aforementioned commit(1ebc93f).

The build of tensorflow fails but I think that's because of other changes in rules_python.
Nevertheless, the build of @pypi_numpy//:pkg is successful, which is what this PR is trying to solve:

INFO: Analyzed target @@pypi_numpy//:pkg (0 packages loaded, 0 targets configured).
INFO: Found 1 target...
Target @@pypi_numpy//:pkg up-to-date:
  bazel-bin/external/pypi_numpy/site-packages/numpy/_core/tests/__init__.py
  bazel-bin/external/pypi_numpy/site-packages/numpy/_core/tests/examples/__init__.py
  bazel-bin/external/pypi_numpy/site-packages/numpy/_core/tests/examples/cython/__init__.py
  bazel-bin/external/pypi_numpy/site-packages/numpy/_core/tests/examples/limited_api/__init__.py
  bazel-bin/external/pypi_numpy/site-packages/numpy/doc/__init__.py
  bazel-bin/external/pypi_numpy/site-packages/numpy/random/_examples/__init__.py
  bazel-bin/external/pypi_numpy/site-packages/numpy/random/_examples/cffi/__init__.py
  bazel-bin/external/pypi_numpy/site-packages/numpy/random/_examples/numba/__init__.py
  bazel-bin/external/pypi_numpy/site-packages/numpy/typing/tests/data/__init__.py
  bazel-bin/external/pypi_numpy/site-packages/numpy/typing/tests/data/pass/__init__.py
INFO: Elapsed time: 4.430s, Critical Path: 0.06s
INFO: 1 process: 1 internal.
INFO: Build completed successfully, 1 total action

bazel-contrib/rules_python#3350

bazel-contrib/rules_python#1907 bazel-contrib/rules_python#3350

tests/pypi/whl_target_platforms/whl_target_platforms_tests.bzl

manylinux_X_Y_* is covered by manylinux_11_12_riscv64 pattern where _11_ and _12_ will be replaced.

bazel-contrib/rules_python#3350

Imported from GitHub PR tensorflow/tensorflow#102607 This commit fixes #102159 which prevented TensorFlow from compiling on RISC-V 64 due to missing codepath in the build system. RFC: Currently this patch overrides timeout of rules_python for all platforms which is obviously not ideal. How do we set pip package timeout here in Tensorflow? See also: - bazelbuild/bazel#25236 - bazelbuild/bazel#25699 - bazel-contrib/rules_python#3350 - #32812 - tensorflow/runtime#135 Copybara import of the project: -- 13b7db883e6ea0aa631490fb5f806c55ceea7cb5 by gns <[email protected]>: [XLA:CPU] Add support for riscv64 Co-authored-by: Levi Zim <[email protected]> -- a00c3a3ba94664798960cbc2fb0a6746fe0c3ac1 by gns <[email protected]>: Add missing llvm:: namespace qualifiers for DTensor Add the `llvm::` namespace prefix to `cast` and `isa` where it was missing in the DTensor MLIR code. -- febc5abc56ab302f5f39fe20176ed00c0c95cb7e by gns <[email protected]>: runtime: add missing stdint header Co-authored-by: Levi Zim <[email protected]> -- 6bf63fec56a6d961b06d932fe69b76eae89d8cb7 by gns <[email protected]>: Add riscv64 support patch for rules_python bazel-contrib/rules_python#3350 -- 68c44fa9613d5577f36c51a192c932795e13ed83 by gns <[email protected]>: tools: py: add riscv64 to pip and manylinux compilance test -- 3f2fe1e0256476449f64658219d997727c9cc534 by gns <[email protected]>: Lift timeout of rules_python for BFS wheels -- 252a9b7ad2336b7abbb94e269b4a976b45d5d6e7 by gns <[email protected]>: Revert llvm toolchain patch for riscv64 As already upstreamed. Co-authored-by: Levi Zim <[email protected]> -- 51047a86131e991ffea74fccb8f55e3521237a64 by gns <[email protected]>: Lift timeout for BFS wheels during pip init -- 3b8276420031969423c9a1f150341a0e41fa372e by gns <[email protected]>: Refresh `rules_python` riscv64 patch Co-authored-by: Levi Zim <[email protected]> Merging this change closes #102607 FUTURE_COPYBARA_INTEGRATE_REVIEW=tensorflow/tensorflow#102607 from infiWang:riscv64 3b8276420031969423c9a1f150341a0e41fa372e PiperOrigin-RevId: 825073762

kxxt requested review from aignas, groodt and rickeylev as code owners October 14, 2025 11:53

gemini-code-assist bot reviewed Oct 14, 2025

View reviewed changes

python/private/pypi/pip_repository.bzl Show resolved Hide resolved

kxxt force-pushed the rv-pip branch 3 times, most recently from f108a9b to 8c0d41d Compare October 14, 2025 12:06

fix: Add linux_riscv64 to _pip_repository_impl

96deeab

Fix bazel-contrib#2729

kxxt force-pushed the rv-pip branch from 8c0d41d to 96deeab Compare October 14, 2025 12:07

Empty commit to retry CI

f03ff72

CI fails with connection timed out

aignas approved these changes Oct 15, 2025

View reviewed changes

Merge branch 'main' into rv-pip

cb1f738

infiWang pushed a commit to infiWang/tensorflow that referenced this pull request Oct 15, 2025

Fix rules_python for riscv64 in XLA and TensorFlow

1705b1e

bazel-contrib/rules_python#3350

infiWang pushed a commit to infiWang/tensorflow that referenced this pull request Oct 15, 2025

Add riscv64 support patch for rules_python

c8b6e68

bazel-contrib/rules_python#1907 bazel-contrib/rules_python#3350

infiWang pushed a commit to infiWang/tensorflow that referenced this pull request Oct 20, 2025

Add riscv64 support patch for rules_python

49706aa

bazel-contrib/rules_python#3350

infiWang added a commit to infiWang/tensorflow that referenced this pull request Oct 20, 2025

Add riscv64 support patch for rules_python

d8cc9de

bazel-contrib/rules_python#3350

infiWang added a commit to infiWang/tensorflow that referenced this pull request Oct 20, 2025

Add riscv64 support patch for rules_python

eff9e17

bazel-contrib/rules_python#3350

infiWang added a commit to infiWang/tensorflow that referenced this pull request Oct 20, 2025

Add riscv64 support patch for rules_python

d9a37d5

bazel-contrib/rules_python#3350

infiWang mentioned this pull request Oct 20, 2025

Add support for Linux RISC-V 64 tensorflow/tensorflow#102607

Open

infiWang added a commit to infiWang/tensorflow that referenced this pull request Oct 20, 2025

Add riscv64 support patch for rules_python

c1bf8d0

bazel-contrib/rules_python#1907 bazel-contrib/rules_python#3350

infiWang reviewed Oct 21, 2025

View reviewed changes

tests/pypi/whl_target_platforms/whl_target_platforms_tests.bzl Outdated Show resolved Hide resolved

kxxt added 2 commits October 25, 2025 09:48

Use real manylinux_2_39_riscv64 for riscv64 in tests

d4a2e1a

Drop "manylinux_2_39_riscv64" from tests

0f23ef4

manylinux_X_Y_* is covered by manylinux_11_12_riscv64 pattern where _11_ and _12_ will be replaced.

aignas approved these changes Oct 26, 2025

View reviewed changes

aignas added this pull request to the merge queue Oct 26, 2025

Merged via the queue into bazel-contrib:main with commit 793dddf Oct 26, 2025
4 checks passed

infiWang added a commit to infiWang/tensorflow that referenced this pull request Oct 29, 2025

Add riscv64 support patch for rules_python

6bf63fe

bazel-contrib/rules_python#3350

rickeylev mentioned this pull request Oct 30, 2025

[XLA:CPU] Add support for riscv64 openxla/xla#32812

Closed

copybara-service bot mentioned this pull request Nov 3, 2025

PR #102607: Add support for Linux RISC-V 64 openxla/xla#33468

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: Add linux_riscv64 to _pip_repository_impl #3350

fix: Add linux_riscv64 to _pip_repository_impl #3350

Uh oh!

kxxt commented Oct 14, 2025 •

edited by aignas

Loading

Uh oh!

gemini-code-assist bot commented Oct 14, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

kxxt commented Oct 14, 2025

Uh oh!

aignas commented Oct 15, 2025 •

edited

Loading

Uh oh!

aignas commented Oct 15, 2025

Uh oh!

kxxt commented Oct 15, 2025

Uh oh!

meteorcloudy commented Oct 15, 2025

Uh oh!

kxxt commented Oct 18, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

fix: Add linux_riscv64 to _pip_repository_impl #3350

fix: Add linux_riscv64 to _pip_repository_impl #3350

Uh oh!

Conversation

kxxt commented Oct 14, 2025 • edited by aignas Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot commented Oct 14, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

kxxt commented Oct 14, 2025

Uh oh!

aignas commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aignas commented Oct 15, 2025

Uh oh!

kxxt commented Oct 15, 2025

Uh oh!

meteorcloudy commented Oct 15, 2025

Uh oh!

kxxt commented Oct 18, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kxxt commented Oct 14, 2025 •

edited by aignas

Loading

aignas commented Oct 15, 2025 •

edited

Loading